cw1200: hwio: Remove an unnecessary goto
authorJoe Perches <joe@perches.com>
Tue, 4 Jun 2013 14:44:50 +0000 (07:44 -0700)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 10 Jun 2013 18:41:25 +0000 (14:41 -0400)
goto after return is wrong.

The other code in this block needs to set an
error value then goto an error release block.

This one doesn't need to release anything and
was likely a copy/paste remainder.

Signed-off-by: Joe Perches <joe@perches.com>
Acked-By: Solomon Peachy <pizza@shaftnet.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/cw1200/hwio.c

index 142f45e..dad3fb3 100644 (file)
@@ -178,7 +178,6 @@ int cw1200_indirect_read(struct cw1200_common *priv, u32 addr, void *buf,
        if ((buf_len / 2) >= 0x1000) {
                pr_err("Can't read more than 0xfff words.\n");
                return -EINVAL;
-               goto out;
        }
 
        priv->hwbus_ops->lock(priv->hwbus_priv);