scsi: ufs: ufs-mediatek: Add put_device() after of_find_device_by_node()
authorYe Guojin <ye.guojin@zte.com.cn>
Wed, 10 Nov 2021 10:51:33 +0000 (10:51 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 19 Nov 2021 03:17:06 +0000 (22:17 -0500)
This was found by coccicheck:

./drivers/scsi/ufs/ufs-mediatek.c, 211, 1-7, ERROR missing put_device;
call of_find_device_by_node on line 1185, but without a corresponding
object release within this function.

Link: https://lore.kernel.org/r/20211110105133.150171-1-ye.guojin@zte.com.cn
Reported-by: Zeal Robot <zealci@zte.com.cn>
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufs-mediatek.c

index fc5b214..5393b5c 100644 (file)
@@ -1189,6 +1189,7 @@ static int ufs_mtk_probe(struct platform_device *pdev)
        }
        link = device_link_add(dev, &reset_pdev->dev,
                DL_FLAG_AUTOPROBE_CONSUMER);
+       put_device(&reset_pdev->dev);
        if (!link) {
                dev_notice(dev, "add reset device_link fail\n");
                goto skip_reset;