cpupower: Fix NULL but dereferenced coccicheck errors
authorShuah Khan <skhan@linuxfoundation.org>
Mon, 29 Jun 2020 20:02:23 +0000 (14:02 -0600)
committerShuah Khan <skhan@linuxfoundation.org>
Mon, 6 Jul 2020 22:11:04 +0000 (16:11 -0600)
Fix NULL but dereferenced coccicheck errors found by:

make coccicheck MODE=report M=tools/power/cpupower

tools/power/cpupower/lib/cpufreq.c:384:19-23: ERROR: first is NULL but dereferenced.
tools/power/cpupower/lib/cpufreq.c:440:19-23: ERROR: first is NULL but dereferenced.
tools/power/cpupower/lib/cpufreq.c:308:19-23: ERROR: first is NULL but dereferenced.
tools/power/cpupower/lib/cpufreq.c:753:19-23: ERROR: first is NULL but dereferenced.

Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/power/cpupower/lib/cpufreq.c

index 6e04304..c3b56db 100644 (file)
@@ -285,7 +285,7 @@ struct cpufreq_available_governors *cpufreq_get_available_governors(unsigned
                        } else {
                                first = malloc(sizeof(*first));
                                if (!first)
-                                       goto error_out;
+                                       return NULL;
                                current = first;
                        }
                        current->first = first;
@@ -362,7 +362,7 @@ struct cpufreq_available_frequencies
                        } else {
                                first = malloc(sizeof(*first));
                                if (!first)
-                                       goto error_out;
+                                       return NULL;
                                current = first;
                        }
                        current->first = first;
@@ -418,7 +418,7 @@ struct cpufreq_available_frequencies
                        } else {
                                first = malloc(sizeof(*first));
                                if (!first)
-                                       goto error_out;
+                                       return NULL;
                                current = first;
                        }
                        current->first = first;
@@ -493,7 +493,7 @@ static struct cpufreq_affected_cpus *sysfs_get_cpu_list(unsigned int cpu,
                        } else {
                                first = malloc(sizeof(*first));
                                if (!first)
-                                       goto error_out;
+                                       return NULL;
                                current = first;
                        }
                        current->first = first;
@@ -726,7 +726,7 @@ struct cpufreq_stats *cpufreq_get_stats(unsigned int cpu,
                        } else {
                                first = malloc(sizeof(*first));
                                if (!first)
-                                       goto error_out;
+                                       return NULL;
                                current = first;
                        }
                        current->first = first;