staging: typec: Fix endianness warning discovered by sparse
authorThomas Gardner <tmg@fastmail.com>
Fri, 7 Jul 2017 00:24:32 +0000 (10:24 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jul 2017 06:40:59 +0000 (08:40 +0200)
The below warning is resolved by removing the cpu_to_le32() call. This
call was redundant; vdm_run_state_machine() ensures that SVDM responses
have the correct endianness before sending.

typec/tcpm.c:1019:49: warning: incorrect type in assignment (different base types)
typec/tcpm.c:1019:49:    expected unsigned int [unsigned] [usertype] <noident>
typec/tcpm.c:1019:49:    got restricted __le32 [usertype] <noident>

Signed-off-by: Thomas Gardner <tmg@fastmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/typec/tcpm.c

index 20eb4eb..2195c80 100644 (file)
@@ -1015,8 +1015,7 @@ static int tcpm_pd_svdm(struct tcpm_port *port, const __le32 *payload, int cnt,
                        if (port->data_role == TYPEC_DEVICE &&
                            port->nr_snk_vdo) {
                                for (i = 0; i <  port->nr_snk_vdo; i++)
-                                       response[i + 1]
-                                               = cpu_to_le32(port->snk_vdo[i]);
+                                       response[i + 1] = port->snk_vdo[i];
                                rlen = port->nr_snk_vdo + 1;
                        }
                        break;