connection: ignore the CANCEL_FD item on asynchronous messages

The doc states that CANCEL_FD should be installed for synchronous, and
for asynchronous messages it should be accepted but ignored, so fix the
code to reflect this.

Signed-off-by: Djalal Harouni <tixxdz@opendz.org>

diff --git a/connection.c b/connection.c
index df05ad57289beb80485e854412044f96b3a0bf0e..587983340c6609949cc477ef891f861a24cf4058 100644 (file)
--- a/connection.c
+++ b/connection.c
@@ -835,6 +835,10 @@ int kdbus_cmd_msg_send(struct kdbus_conn *conn_src,
                        break;
 
                case KDBUS_ITEM_CANCEL_FD:
+                       /* install cancel_fd only if synchronous */
+                       if (!sync)
+                               break;
+
                        if (cancel_fd) {
                                ret = -EEXIST;
                                goto exit_put_cancelfd;