intel_idle: Eliminate __setup_broadcast_timer()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 10 Jan 2020 10:43:23 +0000 (11:43 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 22 Jan 2020 23:36:59 +0000 (00:36 +0100)
The __setup_broadcast_timer() static function is only called in one
place and "true" is passed to it as the argument in there, so
effectively it is a wrapper arround tick_broadcast_enable().

To simplify the code, call tick_broadcast_enable() directly instead
of __setup_broadcast_timer() and drop the latter.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/idle/intel_idle.c

index 1467490..33e353b 100644 (file)
@@ -967,14 +967,6 @@ static bool intel_idle_verify_cstate(unsigned int mwait_hint)
        return true;
 }
 
-static void __setup_broadcast_timer(bool on)
-{
-       if (on)
-               tick_broadcast_enable();
-       else
-               tick_broadcast_disable();
-}
-
 static void auto_demotion_disable(void)
 {
        unsigned long long msr_bits;
@@ -1624,7 +1616,7 @@ static int intel_idle_cpu_online(unsigned int cpu)
        struct cpuidle_device *dev;
 
        if (lapic_timer_reliable_states != LAPIC_TIMER_ALWAYS_RELIABLE)
-               __setup_broadcast_timer(true);
+               tick_broadcast_enable();
 
        /*
         * Some systems can hotplug a cpu at runtime after