projects
/
kernel
/
kernel-generic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a9e2ae3
)
[PATCH] Bogus NULL pointer check in fs/configfs/dir.c
author
Eric Sesterhenn
<snakebyte@gmx.de>
Wed, 22 Mar 2006 23:36:54 +0000
(
00:36
+0100)
committer
Mark Fasheh
<mark.fasheh@oracle.com>
Mon, 10 Apr 2006 18:16:17 +0000
(11:16 -0700)
We check the "group" pointer after we dereference it. This check is
bogus, as it cannot be NULL coming in.
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
fs/configfs/dir.c
patch
|
blob
|
history
diff --git
a/fs/configfs/dir.c
b/fs/configfs/dir.c
index
8ed9b06
..
5638c8f
100644
(file)
--- a/
fs/configfs/dir.c
+++ b/
fs/configfs/dir.c
@@
-504,7
+504,7
@@
static int populate_groups(struct config_group *group)
int ret = 0;
int i;
- if (group
&& group
->default_groups) {
+ if (group->default_groups) {
/* FYI, we're faking mkdir here
* I'm not sure we need this semaphore, as we're called
* from our parent's mkdir. That holds our parent's