Staging: comedi: logical || vs bitwise |
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 17 Jan 2012 07:31:13 +0000 (10:31 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Feb 2012 18:02:22 +0000 (10:02 -0800)
These are bitfields and the intend was to OR them together.  A logical
OR here is simply 1.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/dt9812.c

index 32d9c42..e86ab58 100644 (file)
@@ -527,7 +527,7 @@ static void dt9812_configure_gain(struct usb_dt9812 *dev,
                 * 11x -> Gain =  0.5
                 */
        case DT9812_GAIN_0PT5:
-               rmw->or_value = F020_MASK_ADC0CF_AMP0GN2 ||
+               rmw->or_value = F020_MASK_ADC0CF_AMP0GN2 |
                    F020_MASK_ADC0CF_AMP0GN1;
                break;
        case DT9812_GAIN_1:
@@ -540,7 +540,7 @@ static void dt9812_configure_gain(struct usb_dt9812 *dev,
                rmw->or_value = F020_MASK_ADC0CF_AMP0GN1;
                break;
        case DT9812_GAIN_8:
-               rmw->or_value = F020_MASK_ADC0CF_AMP0GN1 ||
+               rmw->or_value = F020_MASK_ADC0CF_AMP0GN1 |
                    F020_MASK_ADC0CF_AMP0GN0;
                break;
        case DT9812_GAIN_16: