perf auxtrace: Fix address filter symbol name match for modules
authorAdrian Hunter <adrian.hunter@intel.com>
Wed, 26 Oct 2022 07:27:36 +0000 (10:27 +0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 26 Oct 2022 13:49:42 +0000 (10:49 -0300)
For modules, names from kallsyms__parse() contain the module name which
meant that module symbols did not match exactly by name.

Fix by matching the name string up to the separating tab character.

Fixes: 1b36c03e356936d6 ("perf record: Add support for using symbols in address filters")
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20221026072736.2982-1-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/auxtrace.c

index 60d8beb662aa3eaaa38f493633a84d0a0bf0f615..46ada5ec3f9a2ceceb34ea6d3b5258b8f5a0d812 100644 (file)
@@ -2325,11 +2325,19 @@ struct sym_args {
        bool            near;
 };
 
+static bool kern_sym_name_match(const char *kname, const char *name)
+{
+       size_t n = strlen(name);
+
+       return !strcmp(kname, name) ||
+              (!strncmp(kname, name, n) && kname[n] == '\t');
+}
+
 static bool kern_sym_match(struct sym_args *args, const char *name, char type)
 {
        /* A function with the same name, and global or the n'th found or any */
        return kallsyms__is_function(type) &&
-              !strcmp(name, args->name) &&
+              kern_sym_name_match(name, args->name) &&
               ((args->global && isupper(type)) ||
                (args->selected && ++(args->cnt) == args->idx) ||
                (!args->global && !args->selected));