wifi: libertas: cmdresp: don't call kfree_skb() under spin_lock_irqsave()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 7 Dec 2022 15:00:08 +0000 (23:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:32:50 +0000 (09:32 +0100)
[ Upstream commit 708a49a64237f19bd404852f297aaadbc9e7fee0 ]

It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave(). Compile
tested only.

Fixes: f52b041aed77 ("libertas: Add spinlock to avoid race condition")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221207150008.111743-5-yangyingliang@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/marvell/libertas/cmdresp.c

index cb515c5..74cb755 100644 (file)
@@ -48,7 +48,7 @@ void lbs_mac_event_disconnected(struct lbs_private *priv,
 
        /* Free Tx and Rx packets */
        spin_lock_irqsave(&priv->driver_lock, flags);
-       kfree_skb(priv->currenttxskb);
+       dev_kfree_skb_irq(priv->currenttxskb);
        priv->currenttxskb = NULL;
        priv->tx_pending_len = 0;
        spin_unlock_irqrestore(&priv->driver_lock, flags);