staging: rtl8192e: Drop large switch in rtl92e_config_rf
authorMateusz Kulikowski <mateusz.kulikowski@gmail.com>
Tue, 28 Jul 2015 21:31:46 +0000 (23:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 31 Jul 2015 23:21:37 +0000 (16:21 -0700)
The same steps were made for each RF path independently.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c

index 194d64c..c8f25ad 100644 (file)
@@ -122,70 +122,19 @@ bool rtl92e_config_rf(struct net_device *dev)
 
                RetryTimes = ConstRetryTimes;
                RF3_Final_Value = 0;
-               switch (eRFPath) {
-               case RF90_PATH_A:
-                       while (RF3_Final_Value != RegValueToBeCheck &&
-                              RetryTimes != 0) {
-                               ret = rtl92e_config_rf_path(dev,
-                                               (enum rf90_radio_path)eRFPath);
-                               RF3_Final_Value = rtl92e_get_rf_reg(dev,
-                                                (enum rf90_radio_path)eRFPath,
-                                                RegOffSetToBeCheck,
-                                                bMask12Bits);
-                               RT_TRACE(COMP_RF,
-                                        "RF %d %d register final value: %x\n",
-                                        eRFPath, RegOffSetToBeCheck,
-                                        RF3_Final_Value);
-                               RetryTimes--;
-                       }
-                       break;
-               case RF90_PATH_B:
-                       while (RF3_Final_Value != RegValueToBeCheck &&
-                              RetryTimes != 0) {
-                               ret = rtl92e_config_rf_path(dev,
+               while (RF3_Final_Value != RegValueToBeCheck &&
+                      RetryTimes != 0) {
+                       ret = rtl92e_config_rf_path(dev,
                                                (enum rf90_radio_path)eRFPath);
-                               RF3_Final_Value = rtl92e_get_rf_reg(dev,
-                                                (enum rf90_radio_path)eRFPath,
-                                                RegOffSetToBeCheck,
-                                                bMask12Bits);
-                               RT_TRACE(COMP_RF,
-                                        "RF %d %d register final value: %x\n",
-                                        eRFPath, RegOffSetToBeCheck,
-                                        RF3_Final_Value);
-                               RetryTimes--;
-                       }
-                       break;
-               case RF90_PATH_C:
-                       while (RF3_Final_Value != RegValueToBeCheck &&
-                              RetryTimes != 0) {
-                               ret = rtl92e_config_rf_path(dev,
-                                               (enum rf90_radio_path)eRFPath);
-                               RF3_Final_Value = rtl92e_get_rf_reg(dev,
+                       RF3_Final_Value = rtl92e_get_rf_reg(dev,
                                                (enum rf90_radio_path)eRFPath,
                                                RegOffSetToBeCheck,
                                                bMask12Bits);
-                               RT_TRACE(COMP_RF,
-                                        "RF %d %d register final value: %x\n",
-                                        eRFPath, RegOffSetToBeCheck,
-                                        RF3_Final_Value);
-                               RetryTimes--;
-                       }
-                       break;
-               case RF90_PATH_D:
-                       while (RF3_Final_Value != RegValueToBeCheck &&
-                              RetryTimes != 0) {
-                               ret = rtl92e_config_rf_path(dev,
-                                              (enum rf90_radio_path)eRFPath);
-                               RF3_Final_Value = rtl92e_get_rf_reg(dev,
-                                              (enum rf90_radio_path)eRFPath,
-                                              RegOffSetToBeCheck, bMask12Bits);
-                               RT_TRACE(COMP_RF,
-                                        "RF %d %d register final value: %x\n",
-                                        eRFPath, RegOffSetToBeCheck,
-                                        RF3_Final_Value);
-                               RetryTimes--;
-                       }
-                       break;
+                       RT_TRACE(COMP_RF,
+                                "RF %d %d register final value: %x\n",
+                                eRFPath, RegOffSetToBeCheck,
+                                RF3_Final_Value);
+                       RetryTimes--;
                }
 
                switch (eRFPath) {