drm/msm/dpu: Fix for non-visible planes
authorRob Clark <robdclark@chromium.org>
Thu, 7 Jul 2022 21:20:00 +0000 (14:20 -0700)
committerRob Clark <robdclark@chromium.org>
Fri, 8 Jul 2022 15:10:58 +0000 (08:10 -0700)
Fixes `kms_cursor_crc --run-subtest cursor-offscreen`.. when the cursor
moves offscreen the plane becomes non-visible, so we need to skip over
it in crtc atomic test and mixer setup.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/492819/
Link: https://lore.kernel.org/r/20220707212003.1710163-1-robdclark@gmail.com
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

index 4dd0ce0..4ba0009 100644 (file)
@@ -422,6 +422,9 @@ static void _dpu_crtc_blend_setup_mixer(struct drm_crtc *crtc,
                if (!state)
                        continue;
 
+               if (!state->visible)
+                       continue;
+
                pstate = to_dpu_plane_state(state);
                fb = state->fb;
 
@@ -1195,6 +1198,9 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc,
                if (cnt >= DPU_STAGE_MAX * 4)
                        continue;
 
+               if (!pstate->visible)
+                       continue;
+
                pstates[cnt].dpu_pstate = dpu_pstate;
                pstates[cnt].drm_pstate = pstate;
                pstates[cnt].stage = pstate->normalized_zpos;