block: fix busy device checking in blk_drop_partitions again
authorChristoph Hellwig <hch@lst.de>
Fri, 10 Apr 2020 12:31:47 +0000 (14:31 +0200)
committerJens Axboe <axboe@kernel.dk>
Fri, 10 Apr 2020 14:34:11 +0000 (08:34 -0600)
The previous fix had an off by one in the bd_openers checking, counting
the callers blkdev_get.

Fixes: d3ef5536274f ("block: fix busy device checking in blk_drop_partitions")
Reported-by: Qian Cai <cai@lca.pw>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Qian Cai <cai@lca.pw>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/partitions/core.c

index 1a0a829d84169b7eca41006ac49c22d151bf3b10..bc1ded1331b148b5317a662f6f3a97a86ec3f4d1 100644 (file)
@@ -496,7 +496,7 @@ int blk_drop_partitions(struct gendisk *disk, struct block_device *bdev)
 
        if (!disk_part_scan_enabled(disk))
                return 0;
-       if (bdev->bd_part_count || bdev->bd_openers)
+       if (bdev->bd_part_count || bdev->bd_openers > 1)
                return -EBUSY;
        res = invalidate_partition(disk, 0);
        if (res)