PR binutils/15018

	* stabs.c (parse_stab_members): Always set physname here to avoid
	gcc warning..
	(parse_stab_argtypes): ..and don't duplicate the init here.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 585ed8d..5b8916b 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,10 @@
+2013-01-16  Alan Modra  <amodra@gmail.com>
+
+       PR binutils/15018
+       * stabs.c (parse_stab_members): Always set physname here to avoid
+       gcc warning..
+       (parse_stab_argtypes): ..and don't duplicate the init here.
+
 2013-01-10  Will Newton <will.newton@imgtec.com>
 
        * binutils/readelf.c: (guess_is_rela): Add EM_METAG.

diff --git a/binutils/stabs.c b/binutils/stabs.c
index 04c3452..8b45977 100644 (file)
--- a/binutils/stabs.c
+++ b/binutils/stabs.c
@@ -2758,9 +2758,8 @@ parse_stab_members (void *dhandle, struct stab_handle *info,
              argtypes string is the mangled form of the argument
              types, and the full type and the physical name must be
              extracted from them.  */
-         if (! stub)
-           physname = argtypes;
-         else
+         physname = argtypes;
+         if (stub)
            {
              debug_type class_type, return_type;
 
@@ -2879,9 +2878,7 @@ parse_stab_argtypes (void *dhandle, struct stab_handle *info,
                   || CONST_STRNEQ (argtypes, "__dt"));
   is_v3 = argtypes[0] == '_' && argtypes[1] == 'Z';
 
-  if (is_destructor || is_full_physname_constructor || is_v3)
-    *pphysname = argtypes;
-  else
+  if (!(is_destructor || is_full_physname_constructor || is_v3))
     {
       unsigned int len;
       const char *const_prefix;