Fix GWarnings
authorInkyun Kil <inkyun.kil@samsung.com>
Mon, 12 Mar 2018 00:04:36 +0000 (09:04 +0900)
committerInkyun Kil <inkyun.kil@samsung.com>
Tue, 13 Mar 2018 00:19:41 +0000 (09:19 +0900)
Change-Id: I7d1e0a82a73599b9bb4e5052586ac05145f435c8
Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
alarm-manager.c

index 043027c..349c7c4 100644 (file)
@@ -2691,7 +2691,6 @@ gboolean alarm_manager_alarm_create_appsvc(AlarmManager *pObject, GDBusMethodInv
        char log_tag[ALARMMGR_LOG_TAG_SIZE] = {0,};
        char log_message[ALARMMGR_LOG_MESSAGE_SIZE] = {0,};
 #endif
-       bool ret = true;
        int uid;
        int pid;
        const char *name = g_dbus_method_invocation_get_sender(invoc);
@@ -2734,7 +2733,6 @@ gboolean alarm_manager_alarm_create_appsvc(AlarmManager *pObject, GDBusMethodInv
 #ifdef _APPFW_FEATURE_ALARM_MANAGER_MODULE_LOG
                strncpy(log_tag, "FAIL: CREATE", sizeof(log_tag) - 1);
 #endif
-               ret = false;
        } else {
 #ifdef _APPFW_FEATURE_ALARM_MANAGER_MODULE_LOG
                strncpy(log_tag, "CREATE", sizeof(log_tag) - 1);
@@ -2749,7 +2747,7 @@ gboolean alarm_manager_alarm_create_appsvc(AlarmManager *pObject, GDBusMethodInv
        __save_module_log(log_tag, log_message);
 #endif
 
-       return ret;
+       return true;
 }
 
 gboolean alarm_manager_alarm_create_noti(AlarmManager *pObject, GDBusMethodInvocation *invoc,
@@ -2771,7 +2769,6 @@ gboolean alarm_manager_alarm_create_noti(AlarmManager *pObject, GDBusMethodInvoc
        char log_tag[ALARMMGR_LOG_TAG_SIZE] = {0,};
        char log_message[ALARMMGR_LOG_MESSAGE_SIZE] = {0,};
 #endif
-       bool ret = true;
        int uid;
        int pid;
        const char *name = g_dbus_method_invocation_get_sender(invoc);
@@ -2814,7 +2811,6 @@ gboolean alarm_manager_alarm_create_noti(AlarmManager *pObject, GDBusMethodInvoc
 #ifdef _APPFW_FEATURE_ALARM_MANAGER_MODULE_LOG
                strncpy(log_tag, "FAIL: CREATE", sizeof(log_tag) - 1);
 #endif
-               ret = false;
        } else {
 #ifdef _APPFW_FEATURE_ALARM_MANAGER_MODULE_LOG
                strncpy(log_tag, "CREATE", sizeof(log_tag) - 1);
@@ -2829,7 +2825,7 @@ gboolean alarm_manager_alarm_create_noti(AlarmManager *pObject, GDBusMethodInvoc
        __save_module_log(log_tag, log_message);
 #endif
 
-       return ret;
+       return true;
 }
 
 gboolean alarm_manager_alarm_create(AlarmManager *obj, GDBusMethodInvocation *invoc,
@@ -2850,7 +2846,6 @@ gboolean alarm_manager_alarm_create(AlarmManager *obj, GDBusMethodInvocation *in
        char log_tag[ALARMMGR_LOG_TAG_SIZE] = {0,};
        char log_message[ALARMMGR_LOG_MESSAGE_SIZE] = {0,};
 #endif
-       bool ret = true;
        int uid;
        int pid;
        const char *name = g_dbus_method_invocation_get_sender(invoc);
@@ -2895,7 +2890,6 @@ gboolean alarm_manager_alarm_create(AlarmManager *obj, GDBusMethodInvocation *in
 #ifdef _APPFW_FEATURE_ALARM_MANAGER_MODULE_LOG
                strncpy(log_tag, "FAIL: CREATE", sizeof(log_tag) - 1);
 #endif
-               ret = false;
        } else {
 #ifdef _APPFW_FEATURE_ALARM_MANAGER_MODULE_LOG
                strncpy(log_tag, "CREATE", sizeof(log_tag) - 1);
@@ -2910,7 +2904,7 @@ gboolean alarm_manager_alarm_create(AlarmManager *obj, GDBusMethodInvocation *in
        __save_module_log(log_tag, log_message);
 #endif
 
-       return ret;
+       return true;
 }
 
 time_t _get_periodic_alarm_standard_time(void)
@@ -2934,7 +2928,6 @@ gboolean alarm_manager_alarm_create_periodic(AlarmManager *obj, GDBusMethodInvoc
        char log_tag[ALARMMGR_LOG_TAG_SIZE] = {0,};
        char log_message[ALARMMGR_LOG_MESSAGE_SIZE] = {0,};
 #endif
-       bool ret = true;
        int uid;
        int pid;
        const char *name = g_dbus_method_invocation_get_sender(invoc);
@@ -2989,12 +2982,10 @@ gboolean alarm_manager_alarm_create_periodic(AlarmManager *obj, GDBusMethodInvoc
 #ifdef _APPFW_FEATURE_ALARM_MANAGER_MODULE_LOG
                strncpy(log_tag, "FAIL: CREATE", sizeof(log_tag) - 1);
 #endif
-               ret = false;
        } else {
 #ifdef _APPFW_FEATURE_ALARM_MANAGER_MODULE_LOG
                strncpy(log_tag, "CREATE", sizeof(log_tag) - 1);
 #endif
-               ret = true;
        }
 
        g_dbus_method_invocation_return_value(invoc,
@@ -3006,7 +2997,7 @@ gboolean alarm_manager_alarm_create_periodic(AlarmManager *obj, GDBusMethodInvoc
                        alarm_info.start.min, alarm_info.start.sec);
        __save_module_log(log_tag, log_message);
 #endif
-       return ret;
+       return true;
 }
 
 gboolean alarm_manager_alarm_delete(AlarmManager *obj, GDBusMethodInvocation *invoc,
@@ -3017,7 +3008,6 @@ gboolean alarm_manager_alarm_delete(AlarmManager *obj, GDBusMethodInvocation *in
        char log_tag[ALARMMGR_LOG_TAG_SIZE] = {0,};
        char log_message[ALARMMGR_LOG_MESSAGE_SIZE] = {0,};
 #endif
-       bool ret = true;
        int uid;
        int pid;
        const char *name = g_dbus_method_invocation_get_sender(invoc);
@@ -3036,7 +3026,6 @@ gboolean alarm_manager_alarm_delete(AlarmManager *obj, GDBusMethodInvocation *in
 #ifdef _APPFW_FEATURE_ALARM_MANAGER_MODULE_LOG
                strncpy(log_tag, "FAIL: DELETE", sizeof(log_tag) - 1);
 #endif
-               ret = false;
        } else {
                ALARM_MGR_LOG_PRINT("alarm_id[%d] is removed.", alarm_id);
 #ifdef _APPFW_FEATURE_ALARM_MANAGER_MODULE_LOG
@@ -3051,7 +3040,7 @@ gboolean alarm_manager_alarm_delete(AlarmManager *obj, GDBusMethodInvocation *in
        __save_module_log(log_tag, log_message);
 #endif
 
-       return ret;
+       return true;
 }
 
 gboolean alarm_manager_alarm_delete_all(AlarmManager *obj, GDBusMethodInvocation *invoc,
@@ -3146,7 +3135,6 @@ gboolean alarm_manager_alarm_update(AlarmManager *pObj, GDBusMethodInvocation *i
 {
        int return_code = ALARMMGR_RESULT_SUCCESS;
        alarm_info_t alarm_info;
-       bool ret = true;
 #ifdef _APPFW_FEATURE_ALARM_MANAGER_MODULE_LOG
        char log_tag[ALARMMGR_LOG_TAG_SIZE] = {0,};
        char log_message[ALARMMGR_LOG_MESSAGE_SIZE] = {0,};
@@ -3186,7 +3174,6 @@ gboolean alarm_manager_alarm_update(AlarmManager *pObj, GDBusMethodInvocation *i
 #ifdef _APPFW_FEATURE_ALARM_MANAGER_MODULE_LOG
                strncpy(log_tag, "FAIL: UPDATE", sizeof(log_tag) - 1);
 #endif
-               ret = false;
        } else {
 #ifdef _APPFW_FEATURE_ALARM_MANAGER_MODULE_LOG
                strncpy(log_tag, "UPDATE", sizeof(log_tag) - 1);
@@ -3201,7 +3188,7 @@ gboolean alarm_manager_alarm_update(AlarmManager *pObj, GDBusMethodInvocation *i
        __save_module_log(log_tag, log_message);
 #endif
 
-       return ret;
+       return true;
 }
 
 gboolean alarm_manager_alarm_get_number_of_ids(AlarmManager *pObject, GDBusMethodInvocation *invoc,