spi: pxa2xx-pci: Drop unneeded checks in lpss_spi_setup()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 25 Feb 2022 17:23:47 +0000 (19:23 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 28 Feb 2022 12:10:24 +0000 (12:10 +0000)
All of the LPSS devices are using DMA and set the parameters up,
hence no need to test for that.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220225172350.69797-8-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pxa2xx-pci.c

index a0f24e8..c041a92 100644 (file)
@@ -83,6 +83,7 @@ static void lpss_dma_put_device(void *dma_dev)
 
 static int lpss_spi_setup(struct pci_dev *dev, struct pxa_spi_info *c)
 {
+       struct dw_dma_slave *tx, *rx;
        struct pci_dev *dma_dev;
        int ret;
 
@@ -137,21 +138,15 @@ static int lpss_spi_setup(struct pci_dev *dev, struct pxa_spi_info *c)
        if (ret)
                return ret;
 
-       if (c->tx_param) {
-               struct dw_dma_slave *slave = c->tx_param;
-
-               slave->dma_dev = &dma_dev->dev;
-               slave->m_master = 0;
-               slave->p_master = 1;
-       }
-
-       if (c->rx_param) {
-               struct dw_dma_slave *slave = c->rx_param;
+       tx = c->tx_param;
+       tx->dma_dev = &dma_dev->dev;
+       tx->m_master = 0;
+       tx->p_master = 1;
 
-               slave->dma_dev = &dma_dev->dev;
-               slave->m_master = 0;
-               slave->p_master = 1;
-       }
+       rx = c->rx_param;
+       rx->dma_dev = &dma_dev->dev;
+       rx->m_master = 0;
+       rx->p_master = 1;
 
        c->dma_filter = lpss_dma_filter;
        c->dma_burst_size = 1;