nvmet-rdma: removed queue cleanup from module exit
authorSagi Grimberg <sagi@grimberg.me>
Mon, 13 Nov 2017 21:29:05 +0000 (23:29 +0200)
committerChristoph Hellwig <hch@lst.de>
Mon, 8 Jan 2018 10:01:51 +0000 (11:01 +0100)
We already do that when we are notified in device removal
which is triggered when unregistering as an ib client.

Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/target/rdma.c

index 0e4c157..454a5dc 100644 (file)
@@ -1503,25 +1503,9 @@ err_ib_client:
 
 static void __exit nvmet_rdma_exit(void)
 {
-       struct nvmet_rdma_queue *queue;
-
        nvmet_unregister_transport(&nvmet_rdma_ops);
-
-       flush_scheduled_work();
-
-       mutex_lock(&nvmet_rdma_queue_mutex);
-       while ((queue = list_first_entry_or_null(&nvmet_rdma_queue_list,
-                       struct nvmet_rdma_queue, queue_list))) {
-               list_del_init(&queue->queue_list);
-
-               mutex_unlock(&nvmet_rdma_queue_mutex);
-               __nvmet_rdma_queue_disconnect(queue);
-               mutex_lock(&nvmet_rdma_queue_mutex);
-       }
-       mutex_unlock(&nvmet_rdma_queue_mutex);
-
-       flush_scheduled_work();
        ib_unregister_client(&nvmet_rdma_ib_client);
+       WARN_ON_ONCE(!list_empty(&nvmet_rdma_queue_list));
        ida_destroy(&nvmet_rdma_queue_ida);
 }