mtd: don't lock when recursively deleting partitions
authorDavid Bauer <mail@david-bauer.net>
Wed, 17 Feb 2021 19:53:20 +0000 (20:53 +0100)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 11 Mar 2021 08:37:49 +0000 (09:37 +0100)
When recursively deleting partitions, don't acquire the masters
partition lock twice. Otherwise the process ends up in a deadlocked
state.

Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling")
Signed-off-by: David Bauer <mail@david-bauer.net>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20210217195320.893253-1-mail@david-bauer.net
drivers/mtd/mtdpart.c

index 12ca4f1..665fd90 100644 (file)
@@ -331,7 +331,7 @@ static int __del_mtd_partitions(struct mtd_info *mtd)
 
        list_for_each_entry_safe(child, next, &mtd->partitions, part.node) {
                if (mtd_has_partitions(child))
-                       del_mtd_partitions(child);
+                       __del_mtd_partitions(child);
 
                pr_info("Deleting %s MTD partition\n", child->name);
                ret = del_mtd_device(child);