Fix new coverity issues (incorrect deallocator used) 36/225836/1 accepted/tizen/unified/20200225.224448 submit/tizen/20200225.034111
authorDoHyun Pyun <dh79.pyun@samsung.com>
Tue, 25 Feb 2020 02:41:55 +0000 (11:41 +0900)
committerDoHyun Pyun <dh79.pyun@samsung.com>
Tue, 25 Feb 2020 02:41:55 +0000 (11:41 +0900)
Change-Id: I14b80b36c2aeceae3f05c98fca4a236e84aacc7b
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
src/wifi-networkmanager.c
src/wifi-plugin.c
src/wifi-scan.c

index c1083bd..6354a75 100644 (file)
@@ -385,7 +385,7 @@ char* __nm_get_ip_address(void)
                UA_WIFI_ERR("Error in getting ip address");
 
                if (NULL != ip_addr) {
-                       free(ip_addr);
+                       g_free(ip_addr);
                        ip_addr = NULL;
                }
 
index 68b0573..e5e3ef5 100644 (file)
@@ -306,7 +306,7 @@ static gboolean __add_device_send(gpointer data)
 
                        if (NULL == uas_cbs || NULL == uas_cbs->device_added_cb) {
                                dev_list = g_slist_remove(dev_list, wifi_info);
-                               free(wifi_info);
+                               g_free(wifi_info);
                                break;
                        }
 
@@ -315,7 +315,7 @@ static gboolean __add_device_send(gpointer data)
                        if (!dev_info) {
                                UA_WIFI_ERR("Unable to get dev_info");
                                dev_list = g_slist_remove(dev_list, wifi_info);
-                               free(wifi_info);
+                               g_free(wifi_info);
                                break;
                        }
                        /* Save current time */
@@ -346,7 +346,7 @@ static int add_device(uas_device_info_t *device)
        mac_len = strlen(wifi_info->mac_addr);
        ip_len = strlen(wifi_info->ip_addr);
        if (!mac_len && !ip_len) {
-               free(wifi_info);
+               g_free(wifi_info);
                FUNC_EXIT;
                return UAS_STATUS_FAIL;
        }
@@ -434,7 +434,7 @@ static int remove_device(uas_device_info_t *device)
 
                if (!strcasecmp(wifi_info->device_id, device->device_id)) {
                        dev_list = g_slist_remove(dev_list, wifi_info);
-                       free(wifi_info);
+                       g_free(wifi_info);
                        return UAS_STATUS_SUCCESS;
                }
        }
index 44b1421..99a1767 100644 (file)
@@ -48,7 +48,7 @@ static int __arp_packet_make(const char *mac)
 
        if (source_mac == NULL) {
                UA_WIFI_ERR("Wrong Mac address");
-               free(source_mac_address);
+               g_free(source_mac_address);
                return UAS_STATUS_FAIL;
        }
 
@@ -79,7 +79,7 @@ static int __arp_packet_make(const char *mac)
        arp_data->arp.operation = htons(ARPOP_REQUEST); /* ARP op code */
 
        UA_WIFI_INFO("Init arp packet success");
-       free(source_mac_address);
+       g_free(source_mac_address);
        FUNC_EXIT;
        return UAS_STATUS_SUCCESS;
 }
@@ -327,13 +327,13 @@ static int __init_arp(const char *mac)
                net_ifr.ifr_name[if_name_len] = 0;
        } else {
                UA_WIFI_ERR("Error : Interface name is too long");
-               free(iface_name);
+               g_free(iface_name);
                close(arp_data->arp_id);
                arp_data->arp_id = -1;
                return UAS_STATUS_FAIL;
        }
 
-       free(iface_name);
+       g_free(iface_name);
 
        if (ioctl(arp_data->arp_id, SIOCGIFINDEX, &net_ifr) == -1) {
                strerror_r(errno, error_buf, MAX_SIZE_ERROR_BUFFER);