projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
50bec7f
)
regulator: rt4801: Fix NULL pointer dereference if priv->enable_gpios is NULL
author
Axel Lin
<axel.lin@ingics.com>
Thu, 3 Jun 2021 09:49:44 +0000
(17:49 +0800)
committer
Mark Brown
<broonie@kernel.org>
Thu, 3 Jun 2021 18:35:48 +0000
(19:35 +0100)
devm_gpiod_get_array_optional may return NULL if no GPIO was assigned.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Link:
https://lore.kernel.org/r/20210603094944.1114156-1-axel.lin@ingics.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/rt4801-regulator.c
patch
|
blob
|
history
diff --git
a/drivers/regulator/rt4801-regulator.c
b/drivers/regulator/rt4801-regulator.c
index
2055a9c
..
7a87788
100644
(file)
--- a/
drivers/regulator/rt4801-regulator.c
+++ b/
drivers/regulator/rt4801-regulator.c
@@
-66,7
+66,7
@@
static int rt4801_enable(struct regulator_dev *rdev)
struct gpio_descs *gpios = priv->enable_gpios;
int id = rdev_get_id(rdev), ret;
- if (gpios->ndescs <= id) {
+ if (
!gpios ||
gpios->ndescs <= id) {
dev_warn(&rdev->dev, "no dedicated gpio can control\n");
goto bypass_gpio;
}
@@
-88,7
+88,7
@@
static int rt4801_disable(struct regulator_dev *rdev)
struct gpio_descs *gpios = priv->enable_gpios;
int id = rdev_get_id(rdev);
- if (gpios->ndescs <= id) {
+ if (
!gpios ||
gpios->ndescs <= id) {
dev_warn(&rdev->dev, "no dedicated gpio can control\n");
goto bypass_gpio;
}