net/mlx4_en: Fix off-by-one in counters manipulation
authorEran Ben Elisha <eranbe@mellanox.com>
Tue, 5 May 2015 14:07:11 +0000 (17:07 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 5 May 2015 23:39:12 +0000 (19:39 -0400)
This caused the en_stats_adder helper to accumulate a field which is
not related to the counter, fix that.

Fixes: a3333b35da16 ('net/mlx4_en: Moderate ethtool callback to show [..]')
Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/en_port.c

index 54f0e5a..0a56f01 100644 (file)
@@ -139,7 +139,7 @@ static unsigned long en_stats_adder(__be64 *start, __be64 *next, int num)
        int i;
        int offset = next - start;
 
-       for (i = 0; i <= num; i++) {
+       for (i = 0; i < num; i++) {
                ret += be64_to_cpu(*curr);
                curr += offset;
        }