staging: comedi: ni_mio_common: remove deadcode in ni_ai_insn_config()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Mon, 25 Aug 2014 22:23:51 +0000 (15:23 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 Aug 2014 20:20:51 +0000 (13:20 -0700)
The previous mask by 0xf ensures that calib_source will not be > 0xf.
Remove the dead code.

Reported by: coverity
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/ni_mio_common.c

index c42ba22..3c9d747 100644 (file)
@@ -2732,9 +2732,6 @@ static int ni_ai_insn_config(struct comedi_device *dev,
 
                        calib_source = data[1] & 0xf;
 
-                       if (calib_source > 0xF)
-                               return -EINVAL;
-
                        devpriv->ai_calib_source = calib_source;
                        ni_writew(dev, calib_source, Calibration_Channel_6143);
                } else {