pylint for common/manifest.py

C:  1,0: Missing docstring
F: 22,0: Unable to import 'common.utils'
C: 24,0: Operator not preceded by a space
HEADER="""<?xml version="1.0" encoding="UTF-8"?>
      ^
      """
      C: 29,0: Operator not preceded by a space
      XML_ITEM="""<project name="%s" path="%s" revision="%s"/>\n"""
              ^
              C: 30,0: Operator not preceded by a space
              FOOTER="""</manifest>"""
                    ^
                    C: 35,4:gen_repo_manifest: Operator not followed by a space
                        manifest_head = HEADER %(fetch_url, review_url)
                               ^
                               C: 40,8:gen_repo_manifest: Operator not followed by a space
                                       manifest_body +=XML_ITEM %(prj_name, prj_path, revision)
                          ^^
                          C: 67,4:get_repo_primary_md: Operator not preceded by a space
                              ret_data= {}
                                          ^

Change-Id: I1e6b6255fdfd814518adbb4d08e3a484b0f91d2a

diff --git a/common/manifest.py b/common/manifest.py
index b2ebfa3..15a1563 100644 (file)
--- a/common/manifest.py
+++ b/common/manifest.py
@@ -1,3 +1,4 @@
+#!/usr/bin/env python
 # vim: ai ts=4 sts=4 et sw=4
 #
 # Copyright (c) 2012 Intel, Inc.
@@ -15,29 +16,31 @@
 # with this program; if not, write to the Free Software Foundation, Inc., 59
 # Temple Place - Suite 330, Boston, MA 02111-1307, USA.
 
+"""Get info of package or repo from manifest file
+"""
 
 import os
 import gzip
 
 from common.utils import xml2obj
 
-HEADER="""<?xml version="1.0" encoding="UTF-8"?>
+HEADER = """<?xml version="1.0" encoding="UTF-8"?>
 <manifest>
   <remote fetch=\"%s\" name="tizen-gerrit" review=\"%s\"/>
   <default remote="tizen-gerrit"/>
 """
-XML_ITEM="""<project name="%s" path="%s" revision="%s"/>\n"""
-FOOTER="""</manifest>"""
+XML_ITEM = """<project name="%s" path="%s" revision="%s"/>\n"""
+FOOTER = """</manifest>"""
 
 def gen_repo_manifest(data, fetch_url, review_url):
     """ Generate manifest file for android repo tool
     """
-    manifest_head = HEADER %(fetch_url, review_url)
+    manifest_head = HEADER % (fetch_url, review_url)
     manifest_body = ""
     manifest_tail = FOOTER
 
     for prj_name, prj_path, revision in data:
-        manifest_body +=XML_ITEM %(prj_name, prj_path, revision)
+        manifest_body += XML_ITEM % (prj_name, prj_path, revision)
 
     return manifest_head + manifest_body + manifest_tail
 
@@ -64,7 +67,7 @@ def get_repo_primary_md(path_snapshot_base, repo):
     """
 
     # return as dict in {'package_name': "VCS Tag"}
-    ret_data= {}
+    ret_data = {}
 
     build_info = xml2obj(open(os.path.join(path_snapshot_base,
                                           'build.xml')))