devres: handle zero size in devm_kmalloc()
authorBartosz Golaszewski <bgolaszewski@baylibre.com>
Mon, 29 Jun 2020 06:50:06 +0000 (08:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Jul 2020 12:36:02 +0000 (14:36 +0200)
Make devm_kmalloc() behave similarly to non-managed kmalloc(): return
ZERO_SIZE_PTR when requested size is 0. Update devm_kfree() to handle
this case.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Link: https://lore.kernel.org/r/20200629065008.27620-5-brgl@bgdev.pl
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/devres.c

index 1df1fb1..ed615d3 100644 (file)
@@ -819,6 +819,9 @@ void *devm_kmalloc(struct device *dev, size_t size, gfp_t gfp)
 {
        struct devres *dr;
 
+       if (unlikely(!size))
+               return ZERO_SIZE_PTR;
+
        /* use raw alloc_dr for kmalloc caller tracing */
        dr = alloc_dr(devm_kmalloc_release, size, gfp, dev_to_node(dev));
        if (unlikely(!dr))
@@ -950,10 +953,10 @@ void devm_kfree(struct device *dev, const void *p)
        int rc;
 
        /*
-        * Special case: pointer to a string in .rodata returned by
-        * devm_kstrdup_const().
+        * Special cases: pointer to a string in .rodata returned by
+        * devm_kstrdup_const() or NULL/ZERO ptr.
         */
-       if (unlikely(is_kernel_rodata((unsigned long)p)))
+       if (unlikely(is_kernel_rodata((unsigned long)p) || ZERO_OR_NULL_PTR(p)))
                return;
 
        rc = devres_destroy(dev, devm_kmalloc_release,