projects
/
platform
/
framework
/
web
/
crosswalk-tizen.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
16c08e7
)
Initialized rect with zeros
author
Seppe Stas
<seppestas@gmail.com>
Mon, 8 Jun 2015 17:07:46 +0000
(19:07 +0200)
committer
Seppe Stas
<seppestas@gmail.com>
Mon, 8 Jun 2015 17:07:46 +0000
(19:07 +0200)
As per @zcbenz 's remark: The rect should be initialized with zeros to prevent random values being passed to the click event handler when `Shell_NotifyIconGetRect` fails.
atom/browser/ui/win/notify_icon.cc
patch
|
blob
|
history
diff --git
a/atom/browser/ui/win/notify_icon.cc
b/atom/browser/ui/win/notify_icon.cc
index
473a2bc
..
955a047
100644
(file)
--- a/
atom/browser/ui/win/notify_icon.cc
+++ b/
atom/browser/ui/win/notify_icon.cc
@@
-55,7
+55,7
@@
void NotifyIcon::HandleClickEvent(const gfx::Point& cursor_pos,
icon_id.hWnd = window_;
icon_id.cbSize = sizeof(NOTIFYICONIDENTIFIER);
- RECT rect;
+ RECT rect
= { 0 }
;
Shell_NotifyIconGetRect(&icon_id, &rect);
NotifyClicked(gfx::Rect(rect));