ARM: dts: marzen: Add slide switches
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 20 Mar 2023 16:33:22 +0000 (17:33 +0100)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 30 Mar 2023 13:56:26 +0000 (15:56 +0200)
Describe the four General Purpose Switches on the Marzen development
board, so they can be used for user input and/or for wake-up from s2ram.

The GPIO block on R-Car H1 does not support triggering interrupts on
both edges of a changing input signal, hence one cannot use gpio-keys
with gpios properties.  Instead, one of two alternatives needs to be
used:
  1. Use gpio-keys with interrupts instead of gpios properties, at the
     expense of receiving only key presses (release events will be
     auto-generated),
  2. Use gpio-keys-polled with gpios properties, at the expense of
     making these keys unusable as wake-up sources.

As the DTS for the Marzen development board serves mainly as an example,
the approach taken is to use the first alternative for the first two
switches, and the second alternative for the last two switches.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/f834a3c397362f2424fcae6a0c0440356208b182.1679329829.git.geert+renesas@glider.be
arch/arm/boot/dts/r8a7779-marzen.dts

index 5f05f2b..60c9c4b 100644 (file)
@@ -9,6 +9,7 @@
 /dts-v1/;
 #include "r8a7779.dtsi"
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 
 / {
                vdd33a-supply = <&fixedregulator3v3>;
        };
 
+       keyboard-irq {
+               compatible = "gpio-keys";
+
+               pinctrl-0 = <&keyboard_irq_pins>;
+               pinctrl-names = "default";
+
+               interrupt-parent = <&gpio0>;
+
+               key-1 {
+                       interrupts = <17 IRQ_TYPE_EDGE_FALLING>;
+                       linux,code = <KEY_1>;
+                       label = "SW1-1";
+                       wakeup-source;
+                       debounce-interval = <20>;
+               };
+               key-2 {
+                       interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
+                       linux,code = <KEY_2>;
+                       label = "SW1-2";
+                       wakeup-source;
+                       debounce-interval = <20>;
+               };
+       };
+
+       keyboard-gpio {
+               compatible = "gpio-keys-polled";
+               poll-interval = <50>;
+
+               pinctrl-0 = <&keyboard_gpio_pins>;
+               pinctrl-names = "default";
+
+               key-3 {
+                       gpios = <&gpio0 19 GPIO_ACTIVE_LOW>;
+                       linux,code = <KEY_3>;
+                       label = "SW1-3";
+                       debounce-interval = <20>;
+               };
+               key-4 {
+                       gpios = <&gpio0 20 GPIO_ACTIVE_LOW>;
+                       linux,code = <KEY_4>;
+                       label = "SW1-4";
+                       debounce-interval = <20>;
+               };
+       };
+
        leds {
                compatible = "gpio-leds";
                led2 {
        };
 };
 
+&gpio0 {
+       keyboard-irq-hog {
+               gpio-hog;
+               gpios = <17 GPIO_ACTIVE_LOW>, <18 GPIO_ACTIVE_LOW>;
+               input;
+       };
+};
+
 &irqpin0 {
        status = "okay";
 };
                groups = "hspi0";
                function = "hspi0";
        };
+
+       keyboard_irq_pins: keyboard-irq {
+               pins = "GP_0_17", "GP_0_18";
+               bias-pull-up;
+       };
+       keyboard_gpio_pins: keyboard-gpio {
+               pins = "GP_0_19", "GP_0_20";
+               bias-pull-up;
+       };
 };
 
 &sata {