projects
/
platform
/
kernel
/
linux-rpi3.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ce397d2
)
rtc: mrst: fix error code in probe()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Tue, 12 Jun 2018 12:03:02 +0000
(15:03 +0300)
committer
Alexandre Belloni
<alexandre.belloni@bootlin.com>
Wed, 20 Jun 2018 10:43:11 +0000
(12:43 +0200)
We should be returning "retval". The "mrst_rtc.rtc" variable is a valid
pointer.
Fixes:
32b41f93dcaf
("rtc: mrst: switch to devm functions")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-mrst.c
patch
|
blob
|
history
diff --git
a/drivers/rtc/rtc-mrst.c
b/drivers/rtc/rtc-mrst.c
index
097a4d4
..
1925aaf
100644
(file)
--- a/
drivers/rtc/rtc-mrst.c
+++ b/
drivers/rtc/rtc-mrst.c
@@
-367,10
+367,8
@@
static int vrtc_mrst_do_probe(struct device *dev, struct resource *iomem,
}
retval = rtc_register_device(mrst_rtc.rtc);
- if (retval) {
- retval = PTR_ERR(mrst_rtc.rtc);
+ if (retval)
goto cleanup0;
- }
dev_dbg(dev, "initialised\n");
return 0;