media: coda: set debugfs blobs to read only
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 4 May 2021 12:26:48 +0000 (14:26 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 17 Jun 2021 08:20:06 +0000 (10:20 +0200)
Those blobs can only be read. So, don't confuse users with 'writable'
flags.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/coda/coda-common.c

index 2017de8..0e312b0 100644 (file)
@@ -1935,7 +1935,7 @@ int coda_alloc_aux_buf(struct coda_dev *dev, struct coda_aux_buf *buf,
        if (name && parent) {
                buf->blob.data = buf->vaddr;
                buf->blob.size = size;
-               buf->dentry = debugfs_create_blob(name, 0644, parent,
+               buf->dentry = debugfs_create_blob(name, 0444, parent,
                                                  &buf->blob);
        }
 
@@ -3233,7 +3233,7 @@ static int coda_probe(struct platform_device *pdev)
                memset(dev->iram.vaddr, 0, dev->iram.size);
                dev->iram.blob.data = dev->iram.vaddr;
                dev->iram.blob.size = dev->iram.size;
-               dev->iram.dentry = debugfs_create_blob("iram", 0644,
+               dev->iram.dentry = debugfs_create_blob("iram", 0444,
                                                       dev->debugfs_root,
                                                       &dev->iram.blob);
        }