media: dvb-frontends/tda18271c2dd: fix handling of DVB-T parameters
authorDaniel Scheller <d.scheller@gmx.net>
Sun, 24 Jun 2018 13:42:50 +0000 (09:42 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 30 Jul 2018 20:23:12 +0000 (16:23 -0400)
Add a break statement in set_params() for the SYS_DVBT(2).

As reported by gcc:

    drivers/media/dvb-frontends/tda18271c2dd.c:1144:3: warning: this statement may fall through [-Wimplicit-fallthrough=]

There is a nested switch() inside the code with sets the tuner to
the right standard. Without the break, the code will always set to
DVB-C mode, with can be sub-optimal for DVB-T.

Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/dvb-frontends/tda18271c2dd.c

index 2e1d36a..fcffc7b 100644 (file)
@@ -1154,6 +1154,7 @@ static int set_params(struct dvb_frontend *fe)
                default:
                        return -EINVAL;
                }
+               break;
        case SYS_DVBC_ANNEX_A:
        case SYS_DVBC_ANNEX_C:
                if (bw <= 6000000)