gpio: pca953x: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 27 Aug 2020 20:08:25 +0000 (22:08 +0200)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Fri, 28 Aug 2020 18:15:34 +0000 (20:15 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-pca953x.c

index bd2e96c..b5c3e56 100644 (file)
@@ -1000,12 +1000,9 @@ static int pca953x_probe(struct i2c_client *client,
        chip->client = client;
 
        reg = devm_regulator_get(&client->dev, "vcc");
-       if (IS_ERR(reg)) {
-               ret = PTR_ERR(reg);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&client->dev, "reg get err: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(reg))
+               return dev_err_probe(&client->dev, PTR_ERR(reg), "reg get err\n");
+
        ret = regulator_enable(reg);
        if (ret) {
                dev_err(&client->dev, "reg en err: %d\n", ret);