DirectStateAccessTexturesTests: fix textures_parameters_errors
authorAlejandro Piñeiro <apinheiro@igalia.com>
Mon, 20 Feb 2017 12:23:16 +0000 (13:23 +0100)
committerAlexander Galazin <Alexander.Galazin@arm.com>
Fri, 24 Feb 2017 17:00:29 +0000 (12:00 -0500)
Right now GL45-CTS.direct_state_access.textures_parameter_errors
expects INVALID_OPERATION when using a wrong target.

From OpenGL 4.5 spec, section 8.11.2, Texture Parameter Queries:

   "An INVALID_ENUM error is generated if the effective target is not
    one of the texture targets described above."

The test even has a comment about expecting a INVALID_ENUM, so this
seems a typo when calling CheckErrorAndLog

Affects:
GL45-CTS.direct_state_access.textures_parameter_errors

Components: OpenGL

VK-GL-CTS issue: 180

Change-Id: Id82559090ccefa5713b0dd01d0ef26fdf4860ed3

external/openglcts/modules/gl/gl4cDirectStateAccessTexturesTests.cpp

index 8013c26a591b9a1be06e8d7fcd7e79596f96218b..8221379f862d0b3a9b78ab76213eed086deceb5e 100644 (file)
@@ -13168,22 +13168,22 @@ tcu::TestNode::IterateResult ParameterErrorsTest::iterate()
                 not one of the supported texture targets (eg. TEXTURE_BUFFER). */
                gl.getTextureParameterfv(texture_buffer, GL_TEXTURE_TARGET, storef);
                is_ok &=
-                       CheckErrorAndLog(m_context, GL_INVALID_OPERATION, "glGetTextureParameterfv",
+                       CheckErrorAndLog(m_context, GL_INVALID_ENUM, "glGetTextureParameterfv",
                                                         "the effective target is not one of the supported texture targets (eg. TEXTURE_BUFFER).");
 
                gl.getTextureParameterIiv(texture_buffer, GL_TEXTURE_TARGET, storei);
                is_ok &=
-                       CheckErrorAndLog(m_context, GL_INVALID_OPERATION, "glGetTextureParameterIiv",
+                       CheckErrorAndLog(m_context, GL_INVALID_ENUM, "glGetTextureParameterIiv",
                                                         "the effective target is not one of the supported texture targets (eg. TEXTURE_BUFFER).");
 
                gl.getTextureParameterIuiv(texture_buffer, GL_TEXTURE_TARGET, storeu);
                is_ok &=
-                       CheckErrorAndLog(m_context, GL_INVALID_OPERATION, "glGetTextureParameterIuiv",
+                       CheckErrorAndLog(m_context, GL_INVALID_ENUM, "glGetTextureParameterIuiv",
                                                         "the effective target is not one of the supported texture targets (eg. TEXTURE_BUFFER).");
 
                gl.getTextureParameteriv(texture_buffer, GL_TEXTURE_TARGET, storei);
                is_ok &=
-                       CheckErrorAndLog(m_context, GL_INVALID_OPERATION, "glGetTextureParameteriv",
+                       CheckErrorAndLog(m_context, GL_INVALID_ENUM, "glGetTextureParameteriv",
                                                         "the effective target is not one of the supported texture targets (eg. TEXTURE_BUFFER).");
        }
        catch (...)