scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba()
authorTianjia Zhang <tianjia.zhang@linux.alibaba.com>
Sun, 2 Aug 2020 11:15:30 +0000 (19:15 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 25 Aug 2020 03:25:07 +0000 (23:25 -0400)
On an error exit path, a negative error code should be returned instead of
a positive return value.

Link: https://lore.kernel.org/r/20200802111530.5020-1-tianjia.zhang@linux.alibaba.com
Fixes: 8777e4314d39 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine")
Cc: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_nvme.c

index fa695a4..a8da6be 100644 (file)
@@ -678,7 +678,7 @@ int qla_nvme_register_hba(struct scsi_qla_host *vha)
        struct nvme_fc_port_template *tmpl;
        struct qla_hw_data *ha;
        struct nvme_fc_port_info pinfo;
-       int ret = EINVAL;
+       int ret = -EINVAL;
 
        if (!IS_ENABLED(CONFIG_NVME_FC))
                return ret;