powerpc/pseries: Clarify warning when PLPKS password already set
authorAndrew Donnellan <ajd@linux.ibm.com>
Fri, 10 Feb 2023 08:03:56 +0000 (19:03 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Sun, 12 Feb 2023 11:12:38 +0000 (22:12 +1100)
When the H_PKS_GEN_PASSWORD hcall returns H_IN_USE, operations that require
authentication (i.e. anything other than reading a world-readable variable)
will not work.

The current error message doesn't explain this clearly enough. Reword it
to emphasise that authenticated operations will fail.

Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20230210080401.345462-22-ajd@linux.ibm.com
arch/powerpc/platforms/pseries/plpks.c

index 926b6a9..01ae919 100644 (file)
@@ -146,7 +146,7 @@ static int plpks_gen_password(void)
                memcpy(ospassword, password, ospasswordlength);
        } else {
                if (rc == H_IN_USE) {
-                       pr_warn("Password is already set for POWER LPAR Platform KeyStore\n");
+                       pr_warn("Password already set - authenticated operations will fail\n");
                        rc = 0;
                } else {
                        goto out;