RDMA/qedr: Remove the query_pkey callback
authorKamal Heib <kamalheib1@gmail.com>
Tue, 14 Jul 2020 18:34:14 +0000 (21:34 +0300)
committerJason Gunthorpe <jgg@nvidia.com>
Mon, 20 Jul 2020 19:18:17 +0000 (16:18 -0300)
Now that the query_pkey() isn't mandatory by the RDMA core for iwarp
providers, this callback can be removed from the common ops and moved to
the RoCE only ops within the qedr driver.

Link: https://lore.kernel.org/r/20200714183414.61069-8-kamalheib1@gmail.com
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Acked-by: Michal Kalderon <michal.kalderon@marvell.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/qedr/main.c
drivers/infiniband/hw/qedr/verbs.c

index ccaedfd..c9eeed2 100644 (file)
@@ -110,7 +110,6 @@ static int qedr_iw_port_immutable(struct ib_device *ibdev, u8 port_num,
        if (err)
                return err;
 
-       immutable->pkey_tbl_len = 1;
        immutable->gid_tbl_len = 1;
        immutable->core_cap_flags = RDMA_CORE_PORT_IWARP;
        immutable->max_mad_size = 0;
@@ -179,6 +178,7 @@ static int qedr_iw_register_device(struct qedr_dev *dev)
 
 static const struct ib_device_ops qedr_roce_dev_ops = {
        .get_port_immutable = qedr_roce_port_immutable,
+       .query_pkey = qedr_query_pkey,
 };
 
 static void qedr_roce_register_device(struct qedr_dev *dev)
@@ -221,7 +221,6 @@ static const struct ib_device_ops qedr_dev_ops = {
        .post_srq_recv = qedr_post_srq_recv,
        .process_mad = qedr_process_mad,
        .query_device = qedr_query_device,
-       .query_pkey = qedr_query_pkey,
        .query_port = qedr_query_port,
        .query_qp = qedr_query_qp,
        .query_srq = qedr_query_srq,
index fcf2eaa..bd37eaf 100644 (file)
@@ -239,7 +239,6 @@ int qedr_query_port(struct ib_device *ibdev, u8 port, struct ib_port_attr *attr)
        attr->ip_gids = true;
        if (rdma_protocol_iwarp(&dev->ibdev, 1)) {
                attr->gid_tbl_len = 1;
-               attr->pkey_tbl_len = 1;
        } else {
                attr->gid_tbl_len = QEDR_MAX_SGID;
                attr->pkey_tbl_len = QEDR_ROCE_PKEY_TABLE_LEN;