scsi: mvumi: Call scsi_done() directly
authorBart Van Assche <bvanassche@acm.org>
Thu, 7 Oct 2021 20:28:48 +0000 (13:28 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:29:15 +0000 (21:29 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-54-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mvumi.c

index 4d251bf..904de62 100644 (file)
@@ -1328,7 +1328,7 @@ static void mvumi_complete_cmd(struct mvumi_hba *mhba, struct mvumi_cmd *cmd,
                dma_unmap_sg(&mhba->pdev->dev, scsi_sglist(scmd),
                             scsi_sg_count(scmd),
                             scmd->sc_data_direction);
-       cmd->scmd->scsi_done(scmd);
+       scsi_done(scmd);
        mvumi_return_cmd(mhba, cmd);
 }
 
@@ -2104,7 +2104,7 @@ static int mvumi_queue_command(struct Scsi_Host *shost,
 
 out_return_cmd:
        mvumi_return_cmd(mhba, cmd);
-       scmd->scsi_done(scmd);
+       scsi_done(scmd);
        spin_unlock_irqrestore(shost->host_lock, irq_flags);
        return 0;
 }