staging: r8188eu: remove empty function
authorMartin Kaiser <martin@kaiser.cx>
Sat, 7 Aug 2021 15:36:28 +0000 (17:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 10 Aug 2021 10:14:19 +0000 (12:14 +0200)
With the RT_TRACE print removed, the rtw_wx_set_freq function is now
empty.

This function should be removed. At the moment, the setfreq ioctl
returns success to the caller although the frequency wasn't set.
It makes more sense to inform callers that this driver does not
support setfreq.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210807153636.11712-5-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/os_dep/ioctl_linux.c

index 3d26d50..404744c 100644 (file)
@@ -801,13 +801,6 @@ static int rtw_wx_get_name(struct net_device *dev,
        return 0;
 }
 
-static int rtw_wx_set_freq(struct net_device *dev,
-                            struct iw_request_info *info,
-                            union iwreq_data *wrqu, char *extra)
-{
-       return 0;
-}
-
 static int rtw_wx_get_freq(struct net_device *dev,
                             struct iw_request_info *info,
                             union iwreq_data *wrqu, char *extra)
@@ -7437,7 +7430,7 @@ static iw_handler rtw_handlers[] = {
        rtw_wx_get_name,                /* SIOCGIWNAME */
        dummy,                                  /* SIOCSIWNWID */
        dummy,                                  /* SIOCGIWNWID */
-       rtw_wx_set_freq,                /* SIOCSIWFREQ */
+       NULL,                           /* SIOCSIWFREQ */
        rtw_wx_get_freq,                /* SIOCGIWFREQ */
        rtw_wx_set_mode,                /* SIOCSIWMODE */
        rtw_wx_get_mode,                /* SIOCGIWMODE */