staging: r8188eu: simplify dequeue_one_xmitframe
authorMartin Kaiser <martin@kaiser.cx>
Mon, 23 Jan 2023 20:53:34 +0000 (21:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jan 2023 09:10:36 +0000 (10:10 +0100)
Simplify the dequeue_one_xmitframe function without changing its
behaviour. Drop the temporary variable xmitframe_plist.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20230123205342.229589-16-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_xmit.c

index 7802a34..79a1999 100644 (file)
@@ -1357,15 +1357,13 @@ s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitfram
 
 static struct xmit_frame *dequeue_one_xmitframe(struct __queue *pframe_queue)
 {
-       struct list_head *xmitframe_plist, *xmitframe_phead;
+       struct list_head *xmitframe_phead = get_list_head(pframe_queue);
        struct xmit_frame *pxmitframe;
 
-       xmitframe_phead = get_list_head(pframe_queue);
        if (list_empty(xmitframe_phead))
                return NULL;
 
-       xmitframe_plist = xmitframe_phead->next;
-       pxmitframe = container_of(xmitframe_plist, struct xmit_frame, list);
+       pxmitframe = container_of(xmitframe_phead->next, struct xmit_frame, list);
        list_del_init(&pxmitframe->list);
        return pxmitframe;
 }