remoteproc: qcom: wcss: Fix wrong pointer passed to PTR_ERR()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 26 Mar 2021 02:47:41 +0000 (02:47 +0000)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 14 Apr 2021 02:10:32 +0000 (21:10 -0500)
PTR_ERR should access the value just tested by IS_ERR, otherwise
the wrong error code will be returned.

This commit fix it by return 'ret' directly.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 0af65b9b915e ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210326024741.841267-1-weiyongjun1@huawei.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/qcom_q6v5_wcss.c

index 6f7d940..eab911d 100644 (file)
@@ -972,7 +972,7 @@ static int q6v5_wcss_init_clock(struct q6v5_wcss *wcss)
                ret = PTR_ERR(wcss->qdsp6ss_axim_cbcr);
                if (ret != -EPROBE_DEFER)
                        dev_err(wcss->dev, "failed to get axim cbcr clk\n");
-               return PTR_ERR(wcss->qdsp6ss_abhm_cbcr);
+               return ret;
        }
 
        wcss->lcc_bcr_sleep = devm_clk_get(wcss->dev, "lcc_bcr_sleep");