i2c-designware-pci: use dev_err() instead of printk()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 10 Apr 2013 00:36:37 +0000 (00:36 +0000)
committerWolfram Sang <wsa@the-dreams.de>
Mon, 15 Apr 2013 16:16:59 +0000 (18:16 +0200)
With dev_err() we can get the device instance printed as well and is pretty
much standard to use dev_* macros in the drivers anyway. In addition
correct the indentation of probe() arguments.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-designware-pcidrv.c

index 7c5e383..eed149d 100644 (file)
@@ -208,7 +208,7 @@ static u32 i2c_dw_get_clk_rate_khz(struct dw_i2c_dev *dev)
 }
 
 static int i2c_dw_pci_probe(struct pci_dev *pdev,
-const struct pci_device_id *id)
+                           const struct pci_device_id *id)
 {
        struct dw_i2c_dev *dev;
        struct i2c_adapter *adap;
@@ -218,7 +218,7 @@ const struct pci_device_id *id)
        struct  dw_pci_controller *controller;
 
        if (id->driver_data >= ARRAY_SIZE(dw_pci_controllers)) {
-               printk(KERN_ERR "dw_i2c_pci_probe: invalid driver data %ld\n",
+               dev_err(&pdev->dev, "%s: invalid driver data %ld\n", __func__,
                        id->driver_data);
                return -EINVAL;
        }