drm/vc4: Remove redundant error printing in vc4_ioremap_regs()
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 11 May 2021 09:29:23 +0000 (17:29 +0800)
committerMaxime Ripard <maxime@cerno.tech>
Tue, 11 May 2021 14:34:15 +0000 (16:34 +0200)
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20210511092923.4617-1-thunder.leizhen@huawei.com
drivers/gpu/drm/vc4/vc4_drv.c

index 68ac0e7..9eff45b 100644 (file)
@@ -57,10 +57,8 @@ void __iomem *vc4_ioremap_regs(struct platform_device *dev, int index)
 
        res = platform_get_resource(dev, IORESOURCE_MEM, index);
        map = devm_ioremap_resource(&dev->dev, res);
-       if (IS_ERR(map)) {
-               DRM_ERROR("Failed to map registers: %ld\n", PTR_ERR(map));
+       if (IS_ERR(map))
                return map;
-       }
 
        return map;
 }