ASoC: Intel: avs: Use struct_size for struct avs_modcfg_ext size

The struct avs_modcfg_ext structure has a flexible array member for the
pin_fmts array, and the size should be calculated using struct_size to
prevent the potential for overflow with the allocation.

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Reviewed-by: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20230303180457.2457069-1-jacob.e.keller@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/intel/avs/path.c b/sound/soc/intel/avs/path.c
index 05302ab705ae027f036589f6c9d108e9452fe222..adbe23a47847b7b4163828c7401a55caf3fd71f7 100644 (file)
--- a/sound/soc/intel/avs/path.c
+++ b/sound/soc/intel/avs/path.c
@@ -478,7 +478,7 @@ static int avs_modext_create(struct avs_dev *adev, struct avs_path_module *mod)
        int ret, i;
 
        num_pins = tcfg->generic.num_input_pins + tcfg->generic.num_output_pins;
-       cfg_size = sizeof(*cfg) + sizeof(*cfg->pin_fmts) * num_pins;
+       cfg_size = struct_size(cfg, pin_fmts, num_pins);
 
        cfg = kzalloc(cfg_size, GFP_KERNEL);
        if (!cfg)