Fix warnings

Change-Id: Ic9598cb65d7c7838745bb81d57d0dda843c35294
Signed-off-by: pjh9216 <jh9216.park@samsung.com>

diff --git a/src/rust-rpc-port/src/lib.rs b/src/rust-rpc-port/src/lib.rs
index 7b634c2ea8aaeb4a8568d5b55678e1c39d2df7a5..7396586ef475a274885a50d55884d1696378f12b 100644 (file)
--- a/src/rust-rpc-port/src/lib.rs
+++ b/src/rust-rpc-port/src/lib.rs
@@ -1,4 +1,4 @@
-use std::ffi::{c_void, CStr, CString};
+use std::ffi::{c_void, CString};
 use std::os::raw::c_char;
 
 pub mod parcel;
@@ -53,6 +53,7 @@ extern "C" {
 }
 
 impl Port {
+    #[cfg(test)]
     fn new() -> Self {
         Port {
             handle: std::ptr::null_mut(),

diff --git a/src/rust-rpc-port/src/parcel/tests.rs b/src/rust-rpc-port/src/parcel/tests.rs
index 648804bfa58bf42452c5509f8fb0f60fae836978..67c31e8e55cb1df066f54c504323991037304478 100644 (file)
--- a/src/rust-rpc-port/src/parcel/tests.rs
+++ b/src/rust-rpc-port/src/parcel/tests.rs
@@ -87,7 +87,7 @@ fn test_parcel_read_write_string() {
 fn test_parcel_read_write_bundle() {
     let parcel = Parcel::new();
     let mut bundle = Bundle::new();
-    bundle.add_str("key1", "value1");
+    let _ = bundle.add_str("key1", "value1");
     parcel.write_bundle(&bundle);
     let bundle_return = parcel.read_bundle();
     let str_return = bundle_return.get_str("key1").unwrap();
@@ -136,9 +136,9 @@ fn test_parcel_drop() {
 
 #[test]
 fn test_parcel_from_raw() {
-    let mut parcel = Parcel::new();
+    let parcel = Parcel::new();
     parcel.write_str("test");
-    let mut raw = parcel.get_raw();
+    let raw = parcel.get_raw();
     assert_ne!(raw.len(), 0);
     let parcel2 = Parcel::from_raw(&raw);
     let test_str = parcel2.read_string();
@@ -147,7 +147,7 @@ fn test_parcel_from_raw() {
 
 #[test]
 fn test_parcel_get_set_data_size() {
-    let mut parcel = Parcel::new();
+    let parcel = Parcel::new();
 
     parcel.write_str("test");
     parcel.set_data_size(4);
@@ -157,7 +157,7 @@ fn test_parcel_get_set_data_size() {
 
 #[test]
 fn test_parcel_reserve() {
-    let mut parcel = Parcel::new();
+    let parcel = Parcel::new();
 
     parcel.write_str("test");
     parcel.set_data_size(0);
@@ -169,24 +169,24 @@ fn test_parcel_reserve() {
 
 #[test]
 fn test_parcel_pin() {
-    let mut parcel = Parcel::new();
+    let parcel = Parcel::new();
 
     parcel.write_str("test");
     parcel.pin();
 
-    let mut sub_parcel = Parcel::new_from(&parcel, 0, 4);
+    let _sub_parcel = Parcel::new_from(&parcel, 0, 4);
 }
 
 #[test]
 fn test_parcel_create_from_parcel() {
-    let mut parcel = Parcel::new();
+    let parcel = Parcel::new();
     parcel.write_str("test");
     let data_size1 = parcel.get_data_size();
     parcel.write_str("str1");
     let data_size2 = parcel.get_data_size();
     parcel.pin();
 
-    let mut sub_parcel = Parcel::new_from(&parcel, data_size1, data_size2 - data_size1);
+    let sub_parcel = Parcel::new_from(&parcel, data_size1, data_size2 - data_size1);
     sub_parcel.reserve(data_size2 - data_size1);
     let s = sub_parcel.read_string();
 

diff --git a/src/rust-rpc-port/src/proxy/mod.rs b/src/rust-rpc-port/src/proxy/mod.rs
index 11b00ca4556c2aacf355d099918d5dea0d79e3a1..456dd992c294eb8dac8153109f9fe1ac5733b603 100644 (file)
--- a/src/rust-rpc-port/src/proxy/mod.rs
+++ b/src/rust-rpc-port/src/proxy/mod.rs
@@ -7,7 +7,7 @@ pub mod tests;
 
 #[cfg_attr(test, mockall::automock)]
 pub mod ffi {
-    use std::ffi::{c_void, CStr, CString};
+    use std::ffi::c_void;
     use std::os::raw::c_char;
 
     #[link(name = "rpc-port")]
@@ -45,12 +45,13 @@ pub mod ffi {
             cb: extern "C" fn(*const c_char, *const c_char, *mut c_void),
             user_data: *mut c_void,
         ) -> i32;
+
+        #[allow(private_interfaces)]
         pub fn rpc_port_proxy_get_port(
             h: *mut c_void,
             port_type: super::super::CPortType,
             port: *mut *mut c_void,
         ) -> i32;
-
     }
 }
 

diff --git a/src/rust-rpc-port/src/proxy/tests.rs b/src/rust-rpc-port/src/proxy/tests.rs
index 61143eb8c4c95187d7bf3fae31d1314e52c1d91e..907415c81569cc4495e38b547c5d044f56972a7a 100644 (file)
--- a/src/rust-rpc-port/src/proxy/tests.rs
+++ b/src/rust-rpc-port/src/proxy/tests.rs
@@ -5,15 +5,15 @@ use super::{mffi, Proxy, Receive};
 struct Handler {}
 
 impl Receive for Handler {
-    fn on_received(&mut self, receiver: &str, port_name: &str) {}
+    fn on_received(&mut self, _receiver: &str, _port_name: &str) {}
 }
 
 #[test]
 fn test_proxy_try_new_and_drop() {
     let ctx = mffi::rpc_port_proxy_create_context();
-    ctx.expect().times(1).returning(|x| 0);
+    ctx.expect().times(1).returning(|_| 0);
     let ctx_d = mffi::rpc_port_proxy_destroy_context();
-    ctx_d.expect().times(1).returning(|x| 0);
+    ctx_d.expect().times(1).returning(|_| 0);
 
     let _proxy = Proxy::try_new().unwrap();
 }
@@ -21,9 +21,9 @@ fn test_proxy_try_new_and_drop() {
 #[test]
 fn test_proxy_try_connect() {
     let ctx = mffi::rpc_port_proxy_create_context();
-    ctx.expect().times(1).returning(|x| 0);
+    ctx.expect().times(1).returning(|_| 0);
     let ctx_d = mffi::rpc_port_proxy_destroy_context();
-    ctx_d.expect().times(1).returning(|x| 0);
+    ctx_d.expect().times(1).returning(|_| 0);
 
     let ctx_add1 = mffi::rpc_port_proxy_add_connected_event_cb_context();
     ctx_add1.expect().times(1).return_const(0);
@@ -47,7 +47,7 @@ fn test_proxy_try_connect() {
 #[test]
 fn test_proxy_try_connect_sync() {
     let ctx = mffi::rpc_port_proxy_create_context();
-    ctx.expect().times(1).returning(|x| 0);
+    ctx.expect().times(1).returning(|_| 0);
     let ctx_d = mffi::rpc_port_proxy_destroy_context();
     ctx_d.expect().times(1).return_const(0);
 
@@ -73,12 +73,12 @@ fn test_proxy_try_connect_sync() {
 #[test]
 fn test_proxy_get_port() {
     let ctx = mffi::rpc_port_proxy_create_context();
-    ctx.expect().times(1).returning(|x| 0);
+    ctx.expect().times(1).returning(|_| 0);
     let ctx_d = mffi::rpc_port_proxy_destroy_context();
     ctx_d.expect().times(1).return_const(0);
     let ctx_p = mffi::rpc_port_proxy_get_port_context();
     ctx_p.expect().times(1).return_const(0);
 
     let proxy = Proxy::try_new().unwrap();
-    let ret = proxy.get_port(&crate::PortType::Main);
+    let _ = proxy.get_port(&crate::PortType::Main);
 }

diff --git a/src/rust-rpc-port/src/tests.rs b/src/rust-rpc-port/src/tests.rs
index 569c0636736ccd47f41e8b173144b31362490f26..021adbb14920a8ceae8496022cd4e9359a327a6d 100644 (file)
--- a/src/rust-rpc-port/src/tests.rs
+++ b/src/rust-rpc-port/src/tests.rs
@@ -51,5 +51,5 @@ fn test_port_unset_private_sharing_n() {
 #[should_panic]
 fn test_port_get_peer_info_n() {
     let port = Port::new();
-    let (pid, uid) = port.get_peer_info().unwrap();
+    let (_pid, _uid) = port.get_peer_info().unwrap();
 }