mmc: sdhci-of-arasan: Add missed checks for devm_clk_register()
authorChuhong Yuan <hslester96@gmail.com>
Mon, 8 Jun 2020 16:22:26 +0000 (00:22 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 13 Jul 2020 10:18:23 +0000 (12:18 +0200)
These functions do not check the return value of devm_clk_register():
  - sdhci_arasan_register_sdcardclk()
  - sdhci_arasan_register_sampleclk()

Therefore, add the missed checks to fix them.

Fixes: c390f2110adf1 ("mmc: sdhci-of-arasan: Add ability to export card clock")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20200608162226.3259186-1-hslester96@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-of-arasan.c

index db9b544..fb26e74 100644 (file)
@@ -1299,6 +1299,8 @@ sdhci_arasan_register_sdcardclk(struct sdhci_arasan_data *sdhci_arasan,
        clk_data->sdcardclk_hw.init = &sdcardclk_init;
        clk_data->sdcardclk =
                devm_clk_register(dev, &clk_data->sdcardclk_hw);
+       if (IS_ERR(clk_data->sdcardclk))
+               return PTR_ERR(clk_data->sdcardclk);
        clk_data->sdcardclk_hw.init = NULL;
 
        ret = of_clk_add_provider(np, of_clk_src_simple_get,
@@ -1349,6 +1351,8 @@ sdhci_arasan_register_sampleclk(struct sdhci_arasan_data *sdhci_arasan,
        clk_data->sampleclk_hw.init = &sampleclk_init;
        clk_data->sampleclk =
                devm_clk_register(dev, &clk_data->sampleclk_hw);
+       if (IS_ERR(clk_data->sampleclk))
+               return PTR_ERR(clk_data->sampleclk);
        clk_data->sampleclk_hw.init = NULL;
 
        ret = of_clk_add_provider(np, of_clk_src_simple_get,