dma-buf: make fence mandatory for dma_resv_add_excl_fence v2
authorChristian König <christian.koenig@amd.com>
Thu, 11 Nov 2021 09:46:46 +0000 (10:46 +0100)
committerChristian König <christian.koenig@amd.com>
Tue, 30 Nov 2021 14:59:33 +0000 (15:59 +0100)
Calling dma_resv_add_excl_fence() with the fence as NULL and expecting
that that this frees up the fences is simply abuse of the internals of
the dma_resv object.

v2: drop the fence pruning completely.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20211129120659.1815-4-christian.koenig@amd.com
drivers/dma-buf/dma-resv.c

index ff3c0558b3b8f4b0c7e38ce8028a854e341ed935..4deea75c0b9cfa284219f0d4261b0d2d5ffad840 100644 (file)
@@ -305,8 +305,7 @@ void dma_resv_add_excl_fence(struct dma_resv *obj, struct dma_fence *fence)
        if (old)
                i = old->shared_count;
 
-       if (fence)
-               dma_fence_get(fence);
+       dma_fence_get(fence);
 
        write_seqcount_begin(&obj->seq);
        /* write_seqcount_begin provides the necessary memory barrier */