tracing/eprobe: no need to check for negative ret value for snprintf

No need to check for negative return value from snprintf() as the
code does not return negative values.

Link: https://lore.kernel.org/all/20230109040625.3259642-1-quanfafu@gmail.com/
Signed-off-by: Quanfa Fu <quanfafu@gmail.com>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
index 352b65e..594ac1d 100644 (file)
--- a/kernel/trace/trace_eprobe.c
+++ b/kernel/trace/trace_eprobe.c
@@ -923,17 +923,13 @@ static int trace_eprobe_parse_filter(struct trace_eprobe *ep, int argc, const ch
 
        p = ep->filter_str;
        for (i = 0; i < argc; i++) {
-               ret = snprintf(p, len, "%s ", argv[i]);
-               if (ret < 0)
-                       goto error;
-               if (ret > len) {
-                       ret = -E2BIG;
-                       goto error;
-               }
+               if (i)
+                       ret = snprintf(p, len, " %s", argv[i]);
+               else
+                       ret = snprintf(p, len, "%s", argv[i]);
                p += ret;
                len -= ret;
        }
-       p[-1] = '\0';
 
        /*
         * Ensure the filter string can be parsed correctly. Note, this