Ensure QOPENGLF_APIENTRY and QGLF_APIENTRY are set correctly.
authorJason Barron <jason.barron@digia.com>
Mon, 15 Oct 2012 11:28:29 +0000 (13:28 +0200)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Tue, 16 Oct 2012 00:47:46 +0000 (02:47 +0200)
gl2ext.h only defines GL_APIENTRY and not APIENTRY so we should use
this macro if it is available. Without it, code that uses
QOPENGLF_APIENTRY and QGLF_APIENTRY might experience compile errors
due to the differing signatures.

Task-number: QTBUG-27313
Change-Id: Id79d934825928d9913138edc6e8f1b00edc89a8d
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
src/gui/opengl/qopenglfunctions.h
src/opengl/qglfunctions.h

index 54633ff..f035e26 100644 (file)
@@ -83,6 +83,8 @@ typedef ptrdiff_t qopengl_GLsizeiptr;
 
 #if defined(APIENTRY) && !defined(QOPENGLF_APIENTRY)
 #   define QOPENGLF_APIENTRY APIENTRY
+#elif defined(GL_APIENTRY) && !defined(QOPENGLF_APIENTRY)
+#   define QOPENGLF_APIENTRY GL_APIENTRY
 #endif
 
 # ifndef QOPENGLF_APIENTRYP
index 4318f53..3d49b3e 100644 (file)
@@ -63,6 +63,8 @@ typedef ptrdiff_t qgl_GLsizeiptr;
 
 #if defined(APIENTRY) && !defined(QGLF_APIENTRY)
 #   define QGLF_APIENTRY APIENTRY
+#elif defined(GL_APIENTRY) && !defined(QGLF_APIENTRY)
+#   define QGLF_APIENTRY GL_APIENTRY
 #endif
 
 # ifndef QGLF_APIENTRYP