pwm: fsl-ftm: Don't update the state for the caller of pwm_apply_state()
authorUwe Kleine-König <uwe@kleine-koenig.org>
Sat, 24 Aug 2019 15:37:06 +0000 (17:37 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Fri, 20 Sep 2019 23:48:55 +0000 (01:48 +0200)
The pwm-fsl-ftm driver is one of only three PWM drivers which updates
the state for the caller of pwm_apply_state(). This might have
surprising results if the caller reuses the values expecting them to
still represent the same state.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-fsl-ftm.c

index 9d31a21..3c97386 100644 (file)
@@ -292,10 +292,6 @@ static int fsl_pwm_apply_config(struct fsl_pwm_chip *fpc,
 
        regmap_update_bits(fpc->regmap, FTM_POL, BIT(pwm->hwpwm), reg_polarity);
 
-       newstate->period = fsl_pwm_ticks_to_ns(fpc,
-                                              fpc->period.mod_period + 1);
-       newstate->duty_cycle = fsl_pwm_ticks_to_ns(fpc, duty);
-
        ftm_set_write_protection(fpc);
 
        return 0;