PCI: mvebu: Update comment for PCI_EXP_LNKCTL register on emulated bridge
authorPali Rohár <pali@kernel.org>
Tue, 4 Jan 2022 15:35:28 +0000 (16:35 +0100)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Thu, 3 Feb 2022 10:54:06 +0000 (10:54 +0000)
Logic and code for clearing PCI_EXP_LNKCTL_CLKREQ_EN bit is correct, but
comment describing it is misleading. PCI_EXP_LNKCTL_CLKREQ_EN bit should be
hardwired to zero but mvebu hw allows to change it.

Link: https://lore.kernel.org/r/20220104153529.31647-11-pali@kernel.org
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Rob Herring <robh@kernel.org>
drivers/pci/controller/pci-mvebu.c

index 216da12..48098de 100644 (file)
@@ -663,10 +663,9 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
 
        case PCI_EXP_LNKCTL:
                /*
-                * If we don't support CLKREQ, we must ensure that the
-                * CLKREQ enable bit always reads zero.  Since we haven't
-                * had this capability, and it's dependent on board wiring,
-                * disable it for the time being.
+                * PCIe requires that the Enable Clock Power Management bit
+                * is hard-wired to zero for downstream ports but HW allows
+                * to change it.
                 */
                new &= ~PCI_EXP_LNKCTL_CLKREQ_EN;