[Preference] Additional check for unsetChangeListener NotFoundErr 93/76793/1
authorPiotr Kosko <p.kosko@samsung.com>
Mon, 27 Jun 2016 08:56:23 +0000 (10:56 +0200)
committerPiotr Kosko <p.kosko@samsung.com>
Mon, 27 Jun 2016 08:59:19 +0000 (10:59 +0200)
[Feature] Handling NotFoundErr was added in unsetChangeListener()

[Verification] TCT passrate is 97.73% (1 fail caused by TCT issue)

Change-Id: I48be34dbac09ccfd119da2ff400911b7e8e4c0f5
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
src/preference/preference_manager.cc

index b97600409479f63a9e347885fc1884a6e2d9dd9f..2461f3fb989858626dc0488c117a4765b34e3425 100644 (file)
@@ -285,14 +285,13 @@ common::TizenResult PreferenceManager::UnsetChangeListener(const std::string& ke
         if (PREFERENCE_ERROR_NONE != ret) {
           return MakeErrResult(ret, "preference_unset_changed_cb function error");
         }
-
         key_listeners_.erase(it);
-        break;
+        return common::TizenSuccess();
       }
     }
   }
-
-  return common::TizenSuccess();
+  // key was not found
+  return common::NotFoundError(std::string("Listener for given key was not found"));
 }
 
 } // namespace preference