viv-fb: Don't destroy the native FB display
authorJan Schmidt <jan@centricular.com>
Thu, 23 Nov 2017 12:01:52 +0000 (23:01 +1100)
committerJan Schmidt <jan@centricular.com>
Thu, 23 Nov 2017 14:48:32 +0000 (01:48 +1100)
It causes crashes in applications because the result of
fbGetDisplay() might be in use elsewhere in the application
and Vivante doesn't seem to do any refcounting

gst-libs/gst/gl/viv-fb/gstgldisplay_viv_fb.c

index 48815e5..b90273e 100644 (file)
@@ -59,8 +59,8 @@ gst_gl_display_viv_fb_finalize (GObject * object)
 {
   GstGLDisplayVivFB *display_viv_fb = GST_GL_DISPLAY_VIV_FB (object);
 
-  if (display_viv_fb->display)
-    fbDestroyDisplay (display_viv_fb->display);
+  // We don't destroy the FB Display - it causes crashes in applications
+  // because Vivante doesn't seem to do any refcounting
 
   G_OBJECT_CLASS (gst_gl_display_viv_fb_parent_class)->finalize (object);
 }